From: Arnd Bergmann <arnd@xxxxxxxx> The new LED support causes a link failure when the LEDS subsystem is in a loadable module and the playstation HID driver is built-in: ld.lld: error: undefined symbol: devm_led_classdev_multicolor_register_ext >>> referenced by hid-playstation.c >>> hid/hid-playstation.o:(ps_lightbar_register) in archive drivers/built-in.a Add a hard Kconfig dependency on LEDS_CLASS, but allow building with the multicolor support disabled, as this is apparently meant as an optional interface. Fixes: 8c0ab553b072 ("HID: playstation: expose DualSense player LEDs through LED class.") Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx> --- drivers/hid/Kconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig index a2c3d9b7bd01..cd10c398580e 100644 --- a/drivers/hid/Kconfig +++ b/drivers/hid/Kconfig @@ -899,6 +899,8 @@ config HID_PLANTRONICS config HID_PLAYSTATION tristate "PlayStation HID Driver" depends on HID + depends on LEDS_CLASS + depends on LEDS_CLASS_MULTICOLOR || !LEDS_CLASS_MULTICOLOR select CRC32 select POWER_SUPPLY help -- 2.29.2