On Wed, Oct 20, 2021 at 03:44:23PM +0800, lianzhi chang wrote:
> Switching from the desktop environment to the tty environment,
> the state of the keyboard led lights and the state of the keyboard
> lock are inconsistent. This is because the attribute kb->kbdmode
> of the tty bound in the desktop environment (xorg) is set to
Xorg
> VC_OFF, which causes the ledstate and kb->ledflagstate
> values of the bound tty to always be 0, which causes the switch
> from the desktop When to the tty environment, the LED light
> status is inconsistent with the keyboard lock status.
As per Dmitry's remark you need elaborate in the commit message why you can't
do as he suggested.
...
Accordingly to what I see the below has some trailing white spaces,
can you remove them?
> +static void kbd_update_ledstate(struct input_dev *dev)
> +{
> + unsigned long leds = (unsigned long)ledstate;
Why casting?
> +
> + if (test_bit(EV_LED, dev->evbit)) {
> + if (ledstate == -1U)
This is a bit weird, but I see that this should be changed in entire module.
> + ledstate = 0;
> + if (!!test_bit(LED_NUML, dev->led) != !!test_bit(VC_NUMLOCK, &leds))
> + ledstate ^= BIT(VC_NUMLOCK);
> + if (!!test_bit(LED_CAPSL, dev->led) != !!test_bit(VC_CAPSLOCK, &leds))
> + ledstate ^= BIT(VC_CAPSLOCK);
> + if (!!test_bit(LED_SCROLLL, dev->led) != !!test_bit(VC_SCROLLOCK, &leds))
> + ledstate ^= BIT(VC_SCROLLOCK);
> + }
> +}
...
Can this...
> unsigned int leds;
> unsigned long flags;
> + struct kbd_struct *kb = kbd_table + fg_console;
> +
> + if (kb->kbdmode == VC_OFF)
> + return;
...be written as
struct kbd_struct *kb;
unsigned int leds;
unsigned long flags;
kb = kbd_table + fg_console;
if (kb->kbdmode == VC_OFF)
return;
?
--
With Best Regards,
Andy Shevchenko
