On Tue, Oct 19, 2021 at 11:30:06AM +0200, Jiri Kosina wrote: > On Tue, 19 Oct 2021, Emmanuel Gil Peyrot wrote: > > > > The code looks good to me, the only question/request I'd have is -- would > > > it be possible to adhere to the driver naming standards, and actually > > > incorporate the support to existing hid-nintendo driver? Or is there any > > > substantial reason which I don't see why this wouldn't be a good idea? > > > > I don’t see any existing driver named that way in mainline, would it be > > acceptable to simply rename the current patches to hid-nintendo? What > > should be done about the existing hid-wiimote driver then, should it > > also be merged alongside? > > hid-nintendo has just recently been staged for 5.16 in > hid.git#for-5.16/nintendo git branch. Could you please check that? Got it, thanks! > > > Another driver I’d like to submit eventually is the GameCube Controller > > Adapter for Wii U, which does exactly what its name says, but being an > > external USB adapter it also works on any USB computer; would it make > > sense to develop it alongside the current driver, just because it is > > sold by the same company? > > We generally group the support for HID devices in drivers based on the > producing company, with a few exceptions where it doesn't make sense. Would it make sense to decouple this driver from the joycon driver? To have some kind of sub-driver (possibly with Kconfig entries) for joycon, wiimote, drc, gc-adapter, maybe more in the future? I don’t see the drc code go well into that one C file. I can handle the split of the joycon into its own file if that’s a good way forward. > > Thanks, > > -- > Jiri Kosina > SUSE Labs -- Emmanuel Gil Peyrot
Attachment:
signature.asc
Description: PGP signature
