On Mon, Oct 18, 2021 at 08:47:59AM +0200, Andrej Shadura wrote: > The previous commit fixed handling of incomplete packets but broke error > handling: offsetof returns an unsigned value (size_t), but when compared > against the signed return value, the return value is interpreted as if > it were unsigned, so negative return values are never less than the > offset. > > Fixes: 22d65765f211c("HID: u2fzero: ignore incomplete packets without data") > Fixes: 42337b9d4d958("HID: add driver for U2F Zero built-in LED and RNG") Nit, you need a ' ' before the '(' character here, and you only need 12 digits of the sha1. It should look like: Fixes: 22d65765f211 ("HID: u2fzero: ignore incomplete packets without data") Also, how about a cc: stable for these as well? thanks, greg k-h