According to Documentation/filesystems/sysfs.txt: show() methods of device attributes should return the number of bytes printed into the buffer. This is the return value of scnprintf(). snprintf() returns the length the resulting string. So, show() should not use snprintf() when formatting the value to be returned to user space. Also, use sysfs_emit directly makes more sense. Qing Wang (5): hid-lenovo: replace snprintf in show functions with sysfs_emit hid-picolcd: replace snprintf in show functions with sysfs_emit hid-roccat: replace snprintf in show functions with sysfs_emit hid-sensor: replace snprintf in show functions with sysfs_emit hid-sony: replace snprintf in show functions with sysfs_emit drivers/hid/hid-lenovo.c | 16 ++++++++-------- drivers/hid/hid-picolcd_core.c | 6 +++--- drivers/hid/hid-roccat-isku.c | 2 +- drivers/hid/hid-roccat-kone.c | 12 ++++++------ drivers/hid/hid-roccat-koneplus.c | 4 ++-- drivers/hid/hid-roccat-kovaplus.c | 10 +++++----- drivers/hid/hid-roccat-pyra.c | 6 +++--- drivers/hid/hid-sensor-custom.c | 2 +- drivers/hid/hid-sony.c | 6 +++--- 9 files changed, 32 insertions(+), 32 deletions(-) -- 2.7.4