Found when CONFIG_LOGIRUMBLEPAD2_FF was disabled: lg2ff_init() returns -1, and lg_probe() checks the return value and bails out, laterally disabling the device. Fixes: 2dbf635ea1c0 "HID: hid-lg: Check return values from lg[N]ff_init()" Signed-off-by: Benjamin Tissoires <benjamin.tissoires@xxxxxxxxxx> --- drivers/hid/hid-lg.h | 6 +++--- drivers/hid/hid-lg4ff.h | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/hid/hid-lg.h b/drivers/hid/hid-lg.h index 3d8902ba1c6c..dbec5e8fc142 100644 --- a/drivers/hid/hid-lg.h +++ b/drivers/hid/hid-lg.h @@ -10,19 +10,19 @@ struct lg_drv_data { #ifdef CONFIG_LOGITECH_FF int lgff_init(struct hid_device *hdev); #else -static inline int lgff_init(struct hid_device *hdev) { return -1; } +static inline int lgff_init(struct hid_device *hdev) { return 0; } #endif #ifdef CONFIG_LOGIRUMBLEPAD2_FF int lg2ff_init(struct hid_device *hdev); #else -static inline int lg2ff_init(struct hid_device *hdev) { return -1; } +static inline int lg2ff_init(struct hid_device *hdev) { return 0; } #endif #ifdef CONFIG_LOGIG940_FF int lg3ff_init(struct hid_device *hdev); #else -static inline int lg3ff_init(struct hid_device *hdev) { return -1; } +static inline int lg3ff_init(struct hid_device *hdev) { return 0; } #endif #endif diff --git a/drivers/hid/hid-lg4ff.h b/drivers/hid/hid-lg4ff.h index e5c55d515ac2..25bc88cd877e 100644 --- a/drivers/hid/hid-lg4ff.h +++ b/drivers/hid/hid-lg4ff.h @@ -16,8 +16,8 @@ static inline int lg4ff_adjust_input_event(struct hid_device *hid, struct hid_fi struct hid_usage *usage, s32 value, struct lg_drv_data *drv_data) { return 0; } static inline int lg4ff_raw_event(struct hid_device *hdev, struct hid_report *report, u8 *rd, int size, struct lg_drv_data *drv_data) { return 0; } -static inline int lg4ff_init(struct hid_device *hdev) { return -1; } -static inline int lg4ff_deinit(struct hid_device *hdev) { return -1; } +static inline int lg4ff_init(struct hid_device *hdev) { return 0; } +static inline int lg4ff_deinit(struct hid_device *hdev) { return 0; } #endif #endif -- 2.26.3