When possible use dev_err_probe help to properly deal with the
PROBE_DEFER error, the benefit is that DEFER issue will be logged
in the devices_deferred debugfs file.
Using dev_err_probe() can reduce code size, and the error value
gets printed.
Signed-off-by: Cai Huoqing <caihuoqing@xxxxxxxxx>
---
drivers/input/keyboard/samsung-keypad.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/input/keyboard/samsung-keypad.c b/drivers/input/keyboard/samsung-keypad.c
index df0258dcf89e..ed94b042e3b5 100644
--- a/drivers/input/keyboard/samsung-keypad.c
+++ b/drivers/input/keyboard/samsung-keypad.c
@@ -363,10 +363,9 @@ static int samsung_keypad_probe(struct platform_device *pdev)
return -EBUSY;
keypad->clk = devm_clk_get(&pdev->dev, "keypad");
- if (IS_ERR(keypad->clk)) {
- dev_err(&pdev->dev, "failed to get keypad clk\n");
- return PTR_ERR(keypad->clk);
- }
+ if (IS_ERR(keypad->clk))
+ return dev_err_probe(&pdev->dev, PTR_ERR(keypad->clk),
+ "failed to get keypad clk\n");
error = clk_prepare(keypad->clk);
if (error) {
--
2.25.1
