When possible use dev_err_probe help to properly deal with the
PROBE_DEFER error, the benefit is that DEFER issue will be logged
in the devices_deferred debugfs file.
Using dev_err_probe() can reduce code size, and the error value
gets printed.
Signed-off-by: Cai Huoqing <caihuoqing@xxxxxxxxx>
---
drivers/input/matrix-keymap.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/input/matrix-keymap.c b/drivers/input/matrix-keymap.c
index 4fa53423f56c..853657847a7d 100644
--- a/drivers/input/matrix-keymap.c
+++ b/drivers/input/matrix-keymap.c
@@ -100,8 +100,8 @@ static int matrix_keypad_parse_keymap(const char *propname,
retval = device_property_read_u32_array(dev, propname, keys, size);
if (retval) {
- dev_err(dev, "failed to read %s property: %d\n",
- propname, retval);
+ retval = dev_err_probe(dev, retval,
+ "failed to read %s property", propname);
goto out;
}
--
2.25.1
