When possible use dev_err_probe help to properly deal with the PROBE_DEFER error, the benefit is that DEFER issue will be logged in the devices_deferred debugfs file. Using dev_err_probe() can reduce code size, and the error value gets printed. Signed-off-by: Cai Huoqing <caihuoqing@xxxxxxxxx> --- drivers/input/misc/max77693-haptic.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/input/misc/max77693-haptic.c b/drivers/input/misc/max77693-haptic.c index 0d09ffeafeea..e6edf3c96984 100644 --- a/drivers/input/misc/max77693-haptic.c +++ b/drivers/input/misc/max77693-haptic.c @@ -337,10 +337,9 @@ static int max77693_haptic_probe(struct platform_device *pdev) pwm_apply_args(haptic->pwm_dev); haptic->motor_reg = devm_regulator_get(&pdev->dev, "haptic"); - if (IS_ERR(haptic->motor_reg)) { - dev_err(&pdev->dev, "failed to get regulator\n"); - return PTR_ERR(haptic->motor_reg); - } + if (IS_ERR(haptic->motor_reg)) + return dev_err_probe(&pdev->dev, PTR_ERR(haptic->motor_reg), + "failed to get regulator\n"); /* Initialize input device for haptic device */ haptic->input_dev = devm_input_allocate_device(&pdev->dev); -- 2.25.1