When possible use dev_err_probe help to properly deal with the
PROBE_DEFER error, the benefit is that DEFER issue will be logged
in the devices_deferred debugfs file.
Using dev_err_probe() can reduce code size, and the error value
gets printed.
Signed-off-by: Cai Huoqing <caihuoqing@xxxxxxxxx>
---
drivers/input/touchscreen/ad7879.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/input/touchscreen/ad7879.c b/drivers/input/touchscreen/ad7879.c
index e850853328f1..440ebb3fc586 100644
--- a/drivers/input/touchscreen/ad7879.c
+++ b/drivers/input/touchscreen/ad7879.c
@@ -494,10 +494,9 @@ static int ad7879_parse_dt(struct device *dev, struct ad7879 *ts)
u32 tmp;
err = device_property_read_u32(dev, "adi,resistance-plate-x", &tmp);
- if (err) {
- dev_err(dev, "failed to get resistance-plate-x property\n");
- return err;
- }
+ if (err)
+ return dev_err_probe(dev, err,
+ "failed to get resistance-plate-x property\n");
ts->x_plate_ohms = (u16)tmp;
device_property_read_u8(dev, "adi,first-conversion-delay",
--
2.25.1
