Adding Basavaraj -----Original Message----- From: Jiri Kosina <jikos@xxxxxxxxxx> Sent: Wednesday, September 15, 2021 8:28 PM To: Evgeny Novikov <novikov@xxxxxxxxx> Cc: Shah, Nehal-bakulchandra <Nehal-bakulchandra.Shah@xxxxxxx>; Sandeep Singh <sandeep.singh@xxxxxxx>; Benjamin Tissoires <benjamin.tissoires@xxxxxxxxxx>; linux-input@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; ldv-project@xxxxxxxxxxxxxxxx Subject: Re: [PATCH] AMD_SFH: Fix potential NULL pointer dereference On Tue, 1 Jun 2021, Evgeny Novikov wrote: > devm_add_action_or_reset() can suddenly invoke amd_mp2_pci_remove() at > registration that will cause NULL pointer dereference since > corresponding data is not initialized yet. The patch moves > initialization of data before devm_add_action_or_reset(). > > Found by Linux Driver Verification project (linuxtesting.org). > > Signed-off-by: Evgeny Novikov <novikov@xxxxxxxxx> Nehal, Basavaraj, could you please Review/Ack this one? Thanks, -- Jiri Kosina SUSE Labs