On Wed, 19 May 2021, Kenneth Albanowski wrote: > Still as RFC, here's a patch set to implement support for 64-bit > Digitizer Serial Numbers, following on to the prior discussion of how > we can support Usage(Digitizers.Transducer Serial Number) larger > than 32 bits. > > My primary goal is making the serial number available via the > power_supply node interface, and the third patch implements that: if > CONFIG_HID_BATTERY_STRENGTH is enabled, and a hid report includes > both Usage(Digitizers.Battery Strength) and Usage(Digitizers. > Transducer Serial Number) then the generated power_supply node > includes a SERIAL_NUMBER of "DG-ABCDEF..." of the last seen digitizer. > > For this patch set, I have not implemented any changes to MSC_SERIAL*, > however everything should be available for a future implementation. This > patch set does not change any events emitted by evdev. > > After some conversation with Dmitry, I am leaning towards serial number > integration with the hid-multitouch protocol being the better long term > solution for evdev, as that fits better with combined touch and stylus > operation, as well as providing a clear means to providing multiple > serial numbers for simultaneous styluses. > > This set includes general modifications to hid-core to decode and > represent HID fields larger than 32-bits as multiple consecutive 32-bit > words, allowing arbitrarily long fields (or at least as many as can fit > into HID_MAX_BUFFER_SIZE) to be passed upstream and (potentially) > processed by hid-input and other subsystems. > > (After trying a 64-bit implementation, I decided staying with 32-bit > words kept the rest of the hid-core cleaner, and it was worth > supporting arbitrary length fields instead of only upgrading > from 32 -> 64.) Sorry for keeping this on hold for so long, it fell in between cracks. This would need quite an extensive testing by Benjamin's testing infrastructure ... Benjamin, could you please put that into your queue? Other than that, please rework the patchset so that it uses kernel comment styles, it can't be applied in this form. Thanks, -- Jiri Kosina SUSE Labs
