Hi Jonathan, Jonathan Cameron <jic23@xxxxxxxxxx> wrote on Mon, 30 Aug 2021 13:47:14 +0100: > On Wed, 25 Aug 2021 17:24:40 +0200 > Miquel Raynal <miquel.raynal@xxxxxxxxxxx> wrote: > > > There is a very light description of this MFD in a text file dedicated > > to a touchscreen controller (which is one of the two children of the > > MFD). Here is now a complete yaml description. > > Make sure to call out places where you are filling in gaps in the > txt file description. Looks like we forgot to keep that up to date as the driver > evolved. oops. Right, I always forget these links, will update them. > > > > > Signed-off-by: Miquel Raynal <miquel.raynal@xxxxxxxxxxx> > > --- > > .../bindings/mfd/ti,am3359-tscadc.yaml | 75 +++++++++++++++++++ > > 1 file changed, 75 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/mfd/ti,am3359-tscadc.yaml > > > > diff --git a/Documentation/devicetree/bindings/mfd/ti,am3359-tscadc.yaml b/Documentation/devicetree/bindings/mfd/ti,am3359-tscadc.yaml > > new file mode 100644 > > index 000000000000..96b329508d8a > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/mfd/ti,am3359-tscadc.yaml > > @@ -0,0 +1,75 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/mfd/ti,am3359-tscadc.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: TI AM3359 Touchscreen controller/ADC > > + > > +maintainers: > > + - Miquel Raynal <miquel.raynal@xxxxxxxxxxx> > > + > > +properties: > > + compatible: > > + const: ti,am3359-tscadc > > text documents the more specific ti,am654-tscadc as well. Oops, I saw it and then forgot. Thanks for checking! > Something like > > properties: > compatible: > oneof: > - const: ti,am3359-tscadc > - items: > - const: ti,am654-tscadc > - const: ti,am3359-tscadc > > Note this superceeds my comment on later patches about changing to enum when > introducing the new compatible. Ah well. No problem (and thanks for the 50+ reviews btw ;) ) Thanks, Miquèl
