Hi Benjamin, Benjamin Tissoires <benjamin.tissoires@xxxxxxxxxx> writes: > Hi Dmitry, > > On Thu, Aug 12, 2021 at 2:13 AM Dmitry Antipov <daantipov@xxxxxxxxx> wrote: >> >> Surface Duo uses a touch digitizer that communicates to the main SoC via SPI >> and presents itself as a HID device. This patch contains the changes needed >> for the driver to work as a module: HID Core affordances for SPI devices, >> addition of the new Device IDs, and a new quirk in hid-microsoft. The driver >> itself is being prepared for a submission in the near future. >> >> Signed-off-by: Dmitry Antipov dmanti@xxxxxxxxxxxxx > > Though I really appreciate seeing a microsoft.com submission, the > commit description makes me wonder if we should not postpone the > inclusion of this patch with the "submission in the near future". > > AFAIK, HID is not SPI aware. So basically, we are introducing dead > code in the upstream kernel if we take this patch. Right, unfortunately spec isn't public yet (albeit having products shipped using it and a driver available in a public tree somewhere I couldn't find). I _do_ have one question though: Is there a way to tell hid core that $this device wants hidraw? If we remove the hid-microsoft changes, hid-generic will pick the device as expected, but this really needs hidraw. Any hints? -- balbi
