strcpy() performs no bounds checking on the destination buffer. This could result in linear overflows beyond the end of the buffer, leading to all kinds of misbehaviors. The safe replacement is strscpy(). Signed-off-by: Len Baker <len.baker@xxxxxxx> --- This is a task of the KSPP [1] [1] https://github.com/KSPP/linux/issues/88 drivers/input/keyboard/locomokbd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input/keyboard/locomokbd.c b/drivers/input/keyboard/locomokbd.c index dae053596572..dbb3dc48df12 100644 --- a/drivers/input/keyboard/locomokbd.c +++ b/drivers/input/keyboard/locomokbd.c @@ -254,7 +254,7 @@ static int locomokbd_probe(struct locomo_dev *dev) locomokbd->suspend_jiffies = jiffies; locomokbd->input = input_dev; - strcpy(locomokbd->phys, "locomokbd/input0"); + strscpy(locomokbd->phys, "locomokbd/input0", sizeof(locomokbd->phys)); input_dev->name = "LoCoMo keyboard"; input_dev->phys = locomokbd->phys; -- 2.25.1
