hi On 7/14/2021 5:01 AM, Dylan MacKenzie wrote: > [CAUTION: External Email] > > amd_stop_sensor_v2 accidentally used a different MMIO register than > amd_start_sensor_v2 for the DMA address. > > Signed-off-by: Dylan MacKenzie <ecstaticmorse@xxxxxxxxx> Looks good to me. Can you please add a "Fixes:" tag too? With that addressed, Acked-by: Basavaraj Natikar <Basavaraj.Natikar@xxxxxxx> > --- > drivers/hid/amd-sfh-hid/amd_sfh_pcie.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/hid/amd-sfh-hid/amd_sfh_pcie.c b/drivers/hid/amd-sfh-hid/amd_sfh_pcie.c > index 96e2577fa37e..8d68796aa905 100644 > --- a/drivers/hid/amd-sfh-hid/amd_sfh_pcie.c > +++ b/drivers/hid/amd-sfh-hid/amd_sfh_pcie.c > @@ -58,7 +58,7 @@ static void amd_stop_sensor_v2(struct amd_mp2_dev *privdata, u16 sensor_idx) > cmd_base.cmd_v2.sensor_id = sensor_idx; > cmd_base.cmd_v2.length = 16; > > - writeq(0x0, privdata->mmio + AMD_C2P_MSG2); > + writeq(0x0, privdata->mmio + AMD_C2P_MSG1); > writel(cmd_base.ul, privdata->mmio + AMD_C2P_MSG0); > } > > -- > 2.31.1 >
