On Tue, 1 Jun 2021, Jiapeng Chong wrote: > The error code is missing in this code scenario, add the error code > '-EINVAL' to the return value 'error'. > > Eliminate the follow smatch warning: > > drivers/hid/usbhid/hid-pidff.c:1297 hid_pidff_init() warn: missing error > code 'error'. > > Reported-by: Abaci Robot <abaci@xxxxxxxxxxxxxxxxx> > Signed-off-by: Jiapeng Chong <jiapeng.chong@xxxxxxxxxxxxxxxxx> This has already been fixed in hid.git via 3dd653c077efd. Thanks, -- Jiri Kosina SUSE Labs