Hi Erica, Thank you for the patch! Yet something to improve: [auto build test ERROR on hid/for-next] [also build test ERROR on input/next v5.13-rc3] [cannot apply to jikos-hid/for-next next-20210527] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Erica-Taylor/G923-Racing-Wheel-support/20210527-214315 base: https://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git for-next config: alpha-randconfig-r023-20210526 (attached as .config) compiler: alpha-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/ae500b9fb85860a6590531cecf51be335880aa67 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Erica-Taylor/G923-Racing-Wheel-support/20210527-214315 git checkout ae500b9fb85860a6590531cecf51be335880aa67 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=alpha If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@xxxxxxxxx> All errors (new ones prefixed by >>): drivers/input/joystick/xpad.c: In function 'xpad_prepare_next_init_packet': >> drivers/input/joystick/xpad.c:1020:23: error: 'g923_hidpp_init' undeclared (first use in this function) 1020 | memcpy(xpad->odata, g923_hidpp_init, ARRAY_SIZE(g923_hidpp_init)); | ^~~~~~~~~~~~~~~ drivers/input/joystick/xpad.c:1020:23: note: each undeclared identifier is reported only once for each function it appears in In file included from include/linux/bits.h:22, from include/linux/bitops.h:6, from include/linux/kernel.h:11, from drivers/input/joystick/xpad.c:64: >> include/linux/build_bug.h:16:51: error: bit-field '<anonymous>' width not an integer constant 16 | #define BUILD_BUG_ON_ZERO(e) ((int)(sizeof(struct { int:(-!!(e)); }))) | ^ include/linux/compiler.h:240:28: note: in expansion of macro 'BUILD_BUG_ON_ZERO' 240 | #define __must_be_array(a) BUILD_BUG_ON_ZERO(__same_type((a), &(a)[0])) | ^~~~~~~~~~~~~~~~~ include/linux/kernel.h:49:59: note: in expansion of macro '__must_be_array' 49 | #define ARRAY_SIZE(arr) (sizeof(arr) / sizeof((arr)[0]) + __must_be_array(arr)) | ^~~~~~~~~~~~~~~ drivers/input/joystick/xpad.c:1020:40: note: in expansion of macro 'ARRAY_SIZE' 1020 | memcpy(xpad->odata, g923_hidpp_init, ARRAY_SIZE(g923_hidpp_init)); | ^~~~~~~~~~ >> include/linux/build_bug.h:16:51: error: bit-field '<anonymous>' width not an integer constant 16 | #define BUILD_BUG_ON_ZERO(e) ((int)(sizeof(struct { int:(-!!(e)); }))) | ^ include/linux/compiler.h:240:28: note: in expansion of macro 'BUILD_BUG_ON_ZERO' 240 | #define __must_be_array(a) BUILD_BUG_ON_ZERO(__same_type((a), &(a)[0])) | ^~~~~~~~~~~~~~~~~ include/linux/kernel.h:49:59: note: in expansion of macro '__must_be_array' 49 | #define ARRAY_SIZE(arr) (sizeof(arr) / sizeof((arr)[0]) + __must_be_array(arr)) | ^~~~~~~~~~~~~~~ drivers/input/joystick/xpad.c:1021:43: note: in expansion of macro 'ARRAY_SIZE' 1021 | xpad->irq_out->transfer_buffer_length = ARRAY_SIZE(g923_hidpp_init); | ^~~~~~~~~~ At top level: drivers/input/joystick/xpad.c:574:17: warning: 'switch_to_hidpp_cmd' defined but not used [-Wunused-const-variable=] 574 | static const u8 switch_to_hidpp_cmd[] = { | ^~~~~~~~~~~~~~~~~~~ vim +/g923_hidpp_init +1020 drivers/input/joystick/xpad.c 988 989 /* Callers must hold xpad->odata_lock spinlock */ 990 static bool xpad_prepare_next_init_packet(struct usb_xpad *xpad) 991 { 992 const struct xboxone_init_packet *init_packet; 993 994 if (xpad->xtype != XTYPE_XBOXONE) 995 return false; 996 997 /* Perform initialization sequence for Xbox One pads that require it */ 998 while (xpad->init_seq < ARRAY_SIZE(xboxone_init_packets)) { 999 init_packet = &xboxone_init_packets[xpad->init_seq++]; 1000 1001 if (init_packet->idVendor != 0 && 1002 init_packet->idVendor != xpad->dev->id.vendor) 1003 continue; 1004 1005 if (init_packet->idProduct != 0 && 1006 init_packet->idProduct != xpad->dev->id.product) 1007 continue; 1008 1009 /* This packet applies to our device, so prepare to send it */ 1010 memcpy(xpad->odata, init_packet->data, init_packet->len); 1011 xpad->irq_out->transfer_buffer_length = init_packet->len; 1012 1013 /* Update packet with current sequence number */ 1014 xpad->odata[2] = xpad->odata_serial++; 1015 return true; 1016 } 1017 1018 if (switch_to_hidpp && xpad->mapping & HIDPP_CAPABLE) { 1019 dev_dbg(&xpad->intf->dev, "%s - switching to HID++", __func__); > 1020 memcpy(xpad->odata, g923_hidpp_init, ARRAY_SIZE(g923_hidpp_init)); 1021 xpad->irq_out->transfer_buffer_length = ARRAY_SIZE(g923_hidpp_init); 1022 xpad->odata[2] = xpad->odata_serial++; 1023 return true; 1024 } 1025 1026 return false; 1027 } 1028 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
Attachment:
.config.gz
Description: application/gzip
