Hello all, 26.05.2021 23:19, Dmitry Torokhov пишет: > Hi Takashi, > > On Wed, May 26, 2021 at 09:43:01PM +0200, Takashi Iwai wrote: >> The recent change in elants_i2c driver to support more chips >> introduced a regression leading to Oops at probing. The driver reads >> id->driver_data, but the id may be NULL depending on the device type >> the driver gets bound. >> >> Add a NULL check and falls back to the default EKTH3500. > > Thank you for the patch. I think my preference would be to switch to > device_get_match_data() and annotate the rest of the match tables with > proper controller types. Doesn't a NULL mean that elants_i2c_id[] table fails to match the ACPI device name? What is the name then? This could be two patches: 1 - trivial fix that can be backported easily 2 - switch to device_get_match_data()
