On Mon, May 3, 2021 at 11:11 AM Jiri Kosina <jikos@xxxxxxxxxx> wrote: > > On Tue, 20 Apr 2021, наб wrote: > > > > This patchset adds support for stylus-on-touchscreen devices as found on > > > the OneMix 3 Pro and Dell Inspiron 15 7000 2-in-1 (7591), among others; > > > with it, they properly behave like a drawing tablet. > > > > > > Patches 2 and 4 funxionally depend on patch 1. > > > Patch 4 needs patch 3 to apply. > > > > > > The output of this patchset and the need for a kernel, rather than > > > userspace, patch was previously discussed here: > > > https://gitlab.freedesktop.org/libinput/libinput/-/merge_requests/558#note_792834 > > > > > > Changes in v2: > > > Patch 4 now ANDs the secondary button with the tip switch, > > > since it's otherwise borderline useless to the user. > > > > > > Ahelenia Ziemiańska (4): > > > HID: multitouch: require Finger field to mark Win8 reports as MT > > > HID: multitouch: set Stylus suffix for Stylus-application devices, too > > > HID: input: replace outdated HID numbers+comments with macros > > > HID: input: work around Win8 stylus-on-touchscreen reporting > > > > > > drivers/hid/hid-input.c | 54 ++++++++++++++++++++++++++++++++++-- > > > drivers/hid/hid-multitouch.c | 18 +++++++----- > > > 2 files changed, 62 insertions(+), 10 deletions(-) > > > > > > -- > > > 2.20.1 > > > > Bumping this after a monthish ‒ is it missing something? Am I? > > Benjamin had concerns about regressions and wanted to run a full battery > of testing on it. > > Benjamin, is there any outcome of that, please? > Sorry, no real outcome here. I ran the test suite, and there were no errors, until I realized that there are no tests regarding tablets, so it can't detect any regressions here. And then, the usual happens, no time to actually work on the test suite... :( I'll do a "normal" review soon (i.e. today) Cheers, Benjamin
