Hi Joe, On Mon, Apr 19, 2021 at 01:13:25PM +0800, Joe Hung wrote: > Add support for ILITEK Lego series of touch devices. > Lego series includes ILITEK 213X/23XX/25XX. > > Tested/passed with evaluation board with ILI2520/2322 IC. Sorry, I mean to send the email earlier, but I did apply the patches with some minor formatting changes and ... > + > + /* Single touch input setup */ > + input_set_abs_params(input, ABS_X, ts->screen_min_x, > + ts->screen_max_x, 0, 0); > + input_set_abs_params(input, ABS_Y, ts->screen_min_y, > + ts->screen_max_y, 0, 0); You do not need to set up single-axis as ... > + > + /* Multi-touch input setup */ > + input_set_abs_params(input, ABS_MT_POSITION_X, > + ts->screen_min_x, > + ts->screen_max_x, 0, 0); > + input_set_abs_params(input, ABS_MT_POSITION_Y, > + ts->screen_min_y, > + ts->screen_max_y, 0, 0); > + > + touchscreen_parse_properties(input, true, &ts->prop); > + > + error = input_mt_init_slots(input, ts->max_tp, > + INPUT_MT_DIRECT | INPUT_MT_DROP_UNUSED); this will do it for you. Thanks. -- Dmitry