Hi Jiri, This seems to have fallen through the cracks, again (IIRC this is the second resend) can you please pick this series up? Patches 1 - 7 have: Reviewed-by: Marek Behún <kabel@xxxxxxxxxx> Patches 1, 4, 5, 7 have: Acked-by: Pavel Machek <pavel@xxxxxx> With the ack from Pavel (the LED subsys maintainer) indicating that there are no problems with the LED classdev API usage in these patches. Patches 8 - 9 are new in v2 of this series, these add support for the Thinkpad X1 Tablet Thin keyboard. They have been tested by me on a Thinkpad 10 ultra keyboard dock (so that that does not regress) and by Alexander Kobel on a Thinkpad X1 Tablet Thin keyboard. Regards, Hans Hans de Goede (9): HID: lenovo: Use brightness_set_blocking callback for setting LEDs brightness HID: lenovo: Fix lenovo_led_set_tp10ubkbd() error handling HID: lenovo: Check hid_get_drvdata() returns non NULL in lenovo_event() HID: lenovo: Remove lenovo_led_brightness_get() HID: lenovo: Set LEDs max_brightness value HID: lenovo: Map mic-mute button to KEY_F20 instead of KEY_MICMUTE HID: lenovo: Set default_triggers for the mute and micmute LEDs HID: lenovo: Rework how the tp10ubkbd code decides which USB interface to use HID: lenovo: Add support for Thinkpad X1 Tablet Thin keyboard drivers/hid/hid-lenovo.c | 147 ++++++++++++++++++++++++++++++--------- 1 file changed, 114 insertions(+), 33 deletions(-) -- 2.30.2