On Tue, Mar 30, 2021 at 10:54 AM Linus Walleij <linus.walleij@xxxxxxxxxx> wrote: [snip] > > + struct regulator_bulk_data regulators[2]; > struct gpio_desc *reset_gpio; > bool use_hndshk; > u8 act_dist; Wonder if it is worth adding a constant macro for the 2. Patch looks good to me: Reviewed-by: Javier Martinez Canillas <javier@xxxxxxxxxxxx> Best regards, Javier