Re: [PATCH] input: nspire-keypad: enable interrupts only when opened

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Mar 23, 2021 at 10:39:05AM +0100, Fabian Vogt wrote:
> The driver registers an interrupt handler in _probe, but didn't configure
> them until later when the _open function is called. In between, the keypad
> can fire an IRQ due to touchpad activity, which the handler ignores. This
> causes the kernel to disable the interrupt, blocking the keypad from
> working.
> 
> Fix this by disabling interrupts before registering the handler.
> Additionally, disable them in _close, so that they're only enabled while
> open.
> 
> Fixes: fc4f31461892 ("Input: add TI-Nspire keypad support")
> Signed-off-by: Fabian Vogt <fabian@xxxxxxxxxxxxxx>

Applied, thank you.

-- 
Dmitry



[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux