Hi Dmitry, On Mon, Mar 15, 2021 at 10:48 PM Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx> wrote: > > @@ -458,6 +458,7 @@ config KEYBOARD_SNVS_PWRKEY > > config KEYBOARD_IMX > > tristate "IMX keypad support" > > depends on ARCH_MXC || COMPILE_TEST > > + depends on OF > > ARCH_MXC is a stronger constraint than OF, so I wonder if we really need > this. ARCH_MXC does not depend on OF yet, but I agree this is a good suggestion and will submit a patch to do so. For the time being, I will keep the OF dependency in the driver. > If we truly converting this driver then we should also remove references > to dev_get_platdata() and checks for pdev->dev.of_node from > imx_keypad_probe. Good point. I removed them in v2. Thanks
