Hi Dmitry: Was this the only issue with the updated patch? Did it work for you otherwise? -> Yes, the updated patch can work successfully after fix this issue. THANKS JINGLE -----Original Message----- From: 'Dmitry Torokhov' [mailto:dmitry.torokhov@xxxxxxxxx] Sent: Tuesday, March 09, 2021 9:38 AM To: jingle Cc: 'linux-kernel'; 'linux-input'; 'phoenix'; 'dave.wang'; 'josh.chen' Subject: Re: [PATCH] Input: elan_i2c - Reduce the resume time for new dev ices Hi Jingle, On Mon, Mar 08, 2021 at 04:56:14PM +0800, jingle wrote: > Hi Dmitry: > > 1. missing "i<" > + u32 quirks = 0; > + int i; > + > + for (i = 0; ARRAY_SIZE(elan_i2c_quirks); i++) { > > -> for (i = 0; i<ARRAY_SIZE(elan_i2c_quirks); i++) { Yes, you are right of course. Was this the only issue with the updated patch? Did it work for you otherwise? > > 2. elan_resume () funtion are different with at Chromeos driver. > @@ -1384,7 +1422,7 @@ static int __maybe_unused elan_resume(struct > device > *dev) > goto err; > } > > - error = elan_initialize(data); > + error = elan_initialize(data, data->quirks & > ETP_QUIRK_QUICK_WAKEUP); > if (error) > dev_err(dev, "initialize when resuming failed: %d\n", error); > > -> https://chromium.googlesource.com/chromiumos/third_party/kernel/+/r > -> ef > -> s/heads/chromeos-5.4/drivers/input/mouse/elan_i2c_core.c#1434 > -> error = elan_initialize(data); this code is in elan_reactivate() > function at Chromeos driver. > -> Will this change affect cherrypick from linux kernel to chromeos? Yes, we would need to adjust the patch for Chrome OS and have elan_reactivate() to call elan_initialize() with appropriate argument. Thanks. -- Dmitry
