Hi Caleb, On Fri, Mar 05, 2021 at 06:58:10PM +0000, Caleb Connolly wrote: > The touch coordinate register contains the following: > > byte 3 byte 2 byte 1 > +--------+--------+ +-----------------+ +-----------------+ > | | | | | | | > | X[3:0] | Y[3:0] | | Y[11:4] | | X[11:4] | > | | | | | | | > +--------+--------+ +-----------------+ +-----------------+ > > Bytes 2 and 1 need to be shifted left by 4 bits, the least significant > nibble of each is stored in byte 3. Currently they are only > being shifted by 3 causing the reported coordinates to be incorrect. > > This matches downstream examples, and has been confirmed on my > device (OnePlus 7 Pro). > > Fixes: 0145a7141e59 ("Input: add support for the Samsung S6SY761 > touchscreen") > Signed-off-by: Caleb Connolly <caleb@xxxxxxxxxxxxx> Reviewed-by: Andi Shyti <andi@xxxxxxxxxxx> Thanks, Andi