Re: [PATCH v2 5/7] HID: lenovo: Set LEDs max_brightness value

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH v2 5/7] HID: lenovo: Set LEDs max_brightness value
From: Marek Behun <marek.behun@xxxxxx>
Date: Sat, 20 Feb 2021 16:16:45 +0100
Cc: Jiri Kosina <jikos@xxxxxxxxxx>, Benjamin Tissoires <benjamin.tissoires@xxxxxxxxxx>, linux-input@xxxxxxxxxxxxxxx, linux-leds@xxxxxxxxxxxxxxx
In-reply-to: <20210220122438.21857-6-hdegoede@redhat.com>

On Sat, 20 Feb 2021 13:24:36 +0100
Hans de Goede <hdegoede@xxxxxxxxxx> wrote:

> +	data->led_mute.max_brightness = LED_ON;

These constants are obsolete since we now support variable maximum
brightness. Just put 1 there.

Marek

Follow-Ups:
- Re: [PATCH v2 5/7] HID: lenovo: Set LEDs max_brightness value
  - From: Hans de Goede

References:
- [PATCH v2 0/7] HID: lenovo: Mute LED handling fixes and improvements
  - From: Hans de Goede
- [PATCH v2 5/7] HID: lenovo: Set LEDs max_brightness value
  - From: Hans de Goede

Prev by Date: [PATCH v2 1/7] HID: lenovo: Use brightness_set_blocking callback for setting LEDs brightness
Next by Date: [PATCH 1/3] HID: elan: Silence mute LED errors being logged when the device is unplugged
Previous by thread: [PATCH v2 5/7] HID: lenovo: Set LEDs max_brightness value
Next by thread: Re: [PATCH v2 5/7] HID: lenovo: Set LEDs max_brightness value
Index(es):
- Date
- Thread

[Index of Archives] [Linux Media Devel] [Linux USB Devel] [Video for Linux] [Linux Audio Users] [Yosemite News] [Linux Kernel] [Linux SCSI] [Linux Wireless Networking] [Linux Omap]

Powered by Linux