Hi Barnabás and Benjamin, On Fri, Feb 5, 2021 at 8:03 PM Barnabás Pőcze <pobrn@xxxxxxxxxxxxxx> wrote: > > Hi > > > 2021. február 5., péntek 18:01 keltezéssel, Benjamin Tissoires írta: > > > Hi, > > > > On Thu, Jan 28, 2021 at 6:27 PM Roderick Colenbrander > > roderick@xxxxxxxxxx wrote: > > > > > From: Roderick Colenbrander <roderick.colenbrander@xxxxxxxx> > > > Hi, > > > This is hopefully the final revision of this patch series. Patch v4 had > > > a rebase issue of a part of the sensors patch for which a part had moved > > > to the end of the series. This has been fixed. I have double, no triple > > > checked the patches. Made sure they build using a 'rebase -x' script > > > and also ran the hid-tools tests on the final driver. > > > Thanks to everyone who provided feedback through the mailing list or privately. > > > As suggested by Benjamin on the 'v4' version of this email, if you were > > > involed in the review or testing of this series and would like some credit, > > > please provide a reviewed-by or tested-by tag. > > > Changes since v4: > > > > > > - Fixed bad rebase of ps_sensors_create, moved it to appropriate patch. > > > > Barnabás, any comments on this version? > > > > As soon as I get your rev-by, we can apply the series, just in time for 5.12. > > > > Sorry for not responding earlier, I have been relatively busy lately. I have taken > another look at the final source file. I have a couple comments for Roderick: > > - `player_ids` array should be `static const` as far as I can see; > - there are a couple devm_kasprintf() calls which are not checked; > - power_supply_powers() call is not checked - I think either a comment > should mention that it's not considered a fatal error, or checked > > There are also other more minor things, formatting inconsistencies, but I > cannot see anything else, so with the aforementioned things fixed, if you want: > > Reviewed-by: Barnabás Pőcze <pobrn@xxxxxxxxxxxxxx> > Thanks for the additional feedback. I fixed a few additional checkpath warnings and also included these other fixes. I will send out a v6 series tomorrow morning when I'm fresh :) Thanks, Roderick
