From: Colin Ian King <colin.king@xxxxxxxxxxxxx> Currently if the call to qs5xx_fw_file_parse fails the error return exit path will read the uninitialized variable error_bl. Fix this by ensuring error_bl is initialized to zero. Addresses-Coverity: ("Uninitialized scalar variable") Fixes: 2539da6677b6 ("Input: iqs5xx - preserve bootloader errors") Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx> --- drivers/input/touchscreen/iqs5xx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input/touchscreen/iqs5xx.c b/drivers/input/touchscreen/iqs5xx.c index 05e0c6ff217b..54f30038dca4 100644 --- a/drivers/input/touchscreen/iqs5xx.c +++ b/drivers/input/touchscreen/iqs5xx.c @@ -852,7 +852,7 @@ static int iqs5xx_fw_file_parse(struct i2c_client *client, static int iqs5xx_fw_file_write(struct i2c_client *client, const char *fw_file) { struct iqs5xx_private *iqs5xx = i2c_get_clientdata(client); - int error, error_bl; + int error, error_bl = 0; u8 *pmap; if (iqs5xx->bl_status == IQS5XX_BL_STATUS_NONE) -- 2.29.2