On Wed, 2021-01-06 at 18:48 +0000, Filipe Laíns wrote: > On Wed, 2021-01-06 at 10:34 +0100, Bastien Nocera wrote: > > On Mon, 2021-01-04 at 18:29 +0000, lains@xxxxxxxxxxxxx wrote: > > > From: Filipe Laíns <lains@xxxxxxxxxxxxx> > > > > > > This new feature present in new devices replaces the old Battery > > > Level > > > Status (0x1000) feature. It keeps essentially the same > > > information > > > for > > > levels (reporting critical, low, good and full) but makes these > > > levels > > > optional, the device exports a capability setting which describes > > > which > > > levels it supports. In addition to this, there is an optional > > > state_of_charge paramenter that exports the battery percentage. > > > > > > This patch adds support for this new feature. There were some > > > implementation choices, as described below and in the code. > > > > > > If the device supports the state_of_charge parameter, we will > > > just > > > export the battery percentage and not the levels, which the > > > device > > > might > > > still support. > > > > I'm guessing that means no changes needed on the upower side? > > > > Cheers > > > > Yes :) > I tested upower and all works as expected. > > There will still be devices that only support battery voltage, so I > might > implement the battery voltage to charge percentage in a future patch. I sent a WIP patch at the end of November for that, it wasn't even compile-tested, but might be a good base to start from. I don't think that I have any hardware that supports that feature in any case. Cheers
