Re: [PATCH 3/3] Input: st1232 - wait until device is ready before reading resolution

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Dec 29, 2020 at 05:26:01PM +0100, Geert Uytterhoeven wrote:
> According to the st1232 datasheet, the host has to wait for the device
> to change into Normal state before accessing registers other than the
> Status Register.
> 
> If the reset GPIO is wired, the device is powered on during driver
> probe, just before reading the resolution.  However, the latter may
> happen before the device is ready, leading to a probe failure:
> 
>     st1232-ts 1-0055: Failed to read resolution: -6
> 
> Fix this by waiting until the device is ready, by trying to read the
> Status Register until it indicates so, or until timeout.
> 
> On Armadillo 800 EVA, typically the first read fails with an I2C
> transfer error, while the second read indicates the device is ready.
> 
> Fixes: 3a54a215410b1650 ("Input: st1232 - add support resolution reading")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>

Applied, thank you.

-- 
Dmitry



[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux