Re: [PATCH v4] HID: i2c-hid: add polling mode based on connected GPIO chip's pin status

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2020. november 25., szerda 16:07 keltezéssel, Greg KH írta:

> [...]
> > +static u8 polling_mode;
> > +module_param(polling_mode, byte, 0444);
> > +MODULE_PARM_DESC(polling_mode, "How to poll (default=0) - 0 disabled; 1 based on GPIO pin's status");
>
> Module parameters are for the 1990's, they are global and horrible to
> try to work with. You should provide something on a per-device basis,
> as what happens if your system requires different things here for
> different devices? You set this for all devices :(
> [...]

Hi

do you think something like what the usbcore has would be better?
A module parameter like "quirks=<vendor-id>:<product-id>:<flags>[,<vendor-id>:<product-id>:<flags>]*"?


Regards,
Barnabás Pőcze




[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux