Re: [PATCH] Input: cros_ec_keyb - send 'scancodes' in addition to key events

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Dec 7, 2020 at 5:43 PM Dmitry Torokhov
<dmitry.torokhov@xxxxxxxxx> wrote:
>
> To let userspace know what 'scancodes' should be used in EVIOCGKEYCODE
> and EVIOCSKEYCODE ioctls, we should send EV_MSC/MSC_SCAN events in
> addition to EV_KEY/KEY_* events. The driver already declared MSC_SCAN
> capability, so it is only matter of actually sending the events.
>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>
FWIW, Acked-by: Rajat Jain <rajatja@xxxxxxxxxx>


> ---
>  drivers/input/keyboard/cros_ec_keyb.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/input/keyboard/cros_ec_keyb.c b/drivers/input/keyboard/cros_ec_keyb.c
> index 023f083dadd3..354d74d62f05 100644
> --- a/drivers/input/keyboard/cros_ec_keyb.c
> +++ b/drivers/input/keyboard/cros_ec_keyb.c
> @@ -184,6 +184,7 @@ static void cros_ec_keyb_process(struct cros_ec_keyb *ckdev,
>                                         "changed: [r%d c%d]: byte %02x\n",
>                                         row, col, new_state);
>
> +                               input_event(idev, EV_MSC, MSC_SCAN, pos);
>                                 input_report_key(idev, keycodes[pos],
>                                                  new_state);
>                         }
> --
> 2.29.2.576.ga3fc446d84-goog
>
>
> --
> Dmitry



[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux