On Mon, Dec 07, 2020 at 01:30:03PM +0000, Mark Brown wrote: > On Sun, Dec 06, 2020 at 03:27:04AM +0200, Cristian Ciocaltea wrote: > > > +/* > > + * ATC2603C notes: > > + * - LDO8 is not documented in datasheet (v2.4), but supported > > + * in the vendor's driver implementation (xapp-le-kernel). > > + * - LDO12 mentioned in datasheet is not programmable, hence not > > + * handled in this driver. > > + */ > > No reason not to include LDO12 here, the framework supports fixed > regulators fine and the bindings should reflect the physical structure > of the hardware - if something is being supplied by LDO12 on the PMIC > then you'd expect the binding showing a connection from LDO12. Totally agree, I will handle this in the next revision. Thanks, Cristi
