On Fri, Dec 04, 2020 at 09:09:27PM +0100, Uwe Kleine-König wrote: > Hey Greg, > > On Fri, Dec 04, 2020 at 03:58:17PM +0100, Greg Kroah-Hartman wrote: > > On Thu, Nov 26, 2020 at 12:47:24PM +0100, Uwe Kleine-König wrote: > > > The driver core ignores the return value of struct device_driver::remove > > > because there is only little that can be done. To simplify the quest to > > > make this function return void, let struct sa1111_driver::remove return > > > void, too. All users already unconditionally return 0, this commit makes > > > it obvious that returning an error code is a bad idea and ensures future > > > users behave accordingly. > > > > > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> > > > > Reviewed-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> > > Thanks, can I interpret this also as an Ack to take the change affecting > drivers/usb via Russell's tree? Sorry, yes, that is what I was implying here, I should have been more specific. thanks, greg k-h