On Wed, 25 Nov 2020, Pascal.Giard@xxxxxxxxx wrote: > Thank you for reviewing this new version. > > You are right, we could totally do without GHL_GUITAR_CONTROLLER. > > This can be seen as premature generalization or an excess of optimism; > I'm assuming that the PS4 also needs magic control messages to behave > correctly, and that I will figure those sooner than later. But I may be > assuming too much and this will be trivial to add when the time comes. Yeah, let's extend this only when really needed. > Do you want me to submit a v3? Please do, thanks. I'll merge that one, I promise :) Sorry for not having catched this in v1 already. -- Jiri Kosina SUSE Labs
