> -----Original Message----- > From: Lars-Peter Clausen <lars@xxxxxxxxxx> > Sent: Tuesday, November 24, 2020 10:43 AM > To: Ardelean, Alexandru <alexandru.Ardelean@xxxxxxxxxx>; linux- > input@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx > Cc: dmitry.torokhov@xxxxxxxxx > Subject: Re: [PATCH v2 3/3] Input: adp5589-keys - add basic devicetree support > > [External] > > On 11/24/20 9:22 AM, Alexandru Ardelean wrote: > > error = devm_add_action_or_reset(&client->dev, > > adp5589_clear_config, @@ -1078,6 +1098,13 @@ static int __maybe_unused > > adp5589_resume(struct device *dev) > > > > static SIMPLE_DEV_PM_OPS(adp5589_dev_pm_ops, adp5589_suspend, > > adp5589_resume); > > > > +static const struct of_device_id adp5589_of_match[] = { > > + { .compatible = "adi,adp5585", .data = > &adp5589_chip_info_tbl[ADP5585_01] }, > > + { .compatible = "adi,adp5585-02", .data = > &adp5589_chip_info_tbl[ADP5585_02] }, > > + { .compatible = "adi,adp5589", .data = > > +&adp5589_chip_info_tbl[ADP5589] }, > > I think we need to add these to > Documentation/devicetree/bindings/trivial-devices.yaml > Ack Will send a V3 in the next few days.