Hi,
On 11/23/20 2:34 PM, Luo Meng wrote:
> Fix to return a negative error code from the error handling case
> instead of 0 in function i8042_setup_aux(), as done elsewhere in this
> function.
>
> Fixes: f81134163fc7 ("Input: i8042 - use platform_driver_probe")
> Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
> Signed-off-by: Luo Meng <luomeng12@xxxxxxxxxx>
Thanks, patch looks good to me:
Reviewed-by: Hans de Goede <hdegoede@xxxxxxxxxx>
Regards,
Hans
> ---
> drivers/input/serio/i8042.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/input/serio/i8042.c b/drivers/input/serio/i8042.c
> index 944cbb519c6d..abae23af0791 100644
> --- a/drivers/input/serio/i8042.c
> +++ b/drivers/input/serio/i8042.c
> @@ -1471,7 +1471,8 @@ static int __init i8042_setup_aux(void)
> if (error)
> goto err_free_ports;
>
> - if (aux_enable())
> + error = aux_enable();
> + if (error)
> goto err_free_irq;
>
> i8042_aux_irq_registered = true;
>
