Hi Jeff, On Sun, Nov 22, 2020 at 04:39:08PM -0600, Jeff LaBundy wrote: > + > + if ((sys_reg->active & tp_mask) == tp_mask) > + input_set_abs_params(iqs626->trackpad, > + ABS_X, 0, 255, 0, 0); > + else > + input_set_abs_params(iqs626->trackpad, > + ABS_X, 0, 128, 0, 0); > +#ifdef CONFIG_TOUCHSCREEN_PROPERTIES > + touchscreen_parse_properties(iqs626->trackpad, false, > + &iqs626->prop); > +#endif /* CONFIG_TOUCHSCREEN_PROPERTIES */ This should not be separately selectable from CONFIG_INPUT, so there is not need to have this guard. The reason it is a separate symbol is historical - it used to depend on OF in addition to INPUT. I suppose I can drop it now. Thanks. -- Dmitry