> -----Original Message----- > From: Lee Jones [mailto:lee.jones@xxxxxxxxxx] > Sent: 2020年11月12日 19:02 > To: lee.jones@xxxxxxxxxx > Cc: linux-kernel@xxxxxxxxxxxxxxx; Dmitry Torokhov > <dmitry.torokhov@xxxxxxxxx>; Shawn Guo <shawnguo@xxxxxxxxxx>; Sascha > Hauer <s.hauer@xxxxxxxxxxxxxx>; Pengutronix Kernel Team > <kernel@xxxxxxxxxxxxxx>; Fabio Estevam <festevam@xxxxxxxxx>; > dl-linux-imx <linux-imx@xxxxxxx>; Haibo Chen <haibo.chen@xxxxxxxxxxxxx>; > linux-input@xxxxxxxxxxxxxxx > Subject: [PATCH 05/15] input: touchscreen: imx6ul_tsc: Remove set but unused > variable 'value' > > Fixes the following W=1 kernel build warning(s): > > drivers/input/touchscreen/imx6ul_tsc.c: In function ‘adc_irq_fn’: > drivers/input/touchscreen/imx6ul_tsc.c:307:6: warning: variable ‘value’ set > but not used [-Wunused-but-set-variable] > > Cc: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx> > Cc: Shawn Guo <shawnguo@xxxxxxxxxx> > Cc: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> > Cc: Pengutronix Kernel Team <kernel@xxxxxxxxxxxxxx> > Cc: Fabio Estevam <festevam@xxxxxxxxx> > Cc: NXP Linux Team <linux-imx@xxxxxxx> > Cc: Haibo Chen <haibo.chen@xxxxxxxxxxxxx> > Cc: linux-input@xxxxxxxxxxxxxxx > Signed-off-by: Lee Jones <lee.jones@xxxxxxxxxx> > --- > drivers/input/touchscreen/imx6ul_tsc.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/input/touchscreen/imx6ul_tsc.c > b/drivers/input/touchscreen/imx6ul_tsc.c > index cd369f9ac5e60..e1852f7d4d31e 100644 > --- a/drivers/input/touchscreen/imx6ul_tsc.c > +++ b/drivers/input/touchscreen/imx6ul_tsc.c > @@ -304,11 +304,10 @@ static irqreturn_t adc_irq_fn(int irq, void *dev_id) > { > struct imx6ul_tsc *tsc = dev_id; > u32 coco; > - u32 value; > > coco = readl(tsc->adc_regs + REG_ADC_HS); > if (coco & 0x01) { > - value = readl(tsc->adc_regs + REG_ADC_R0); > + readl(tsc->adc_regs + REG_ADC_R0); > complete(&tsc->completion); > } > Reviewed-by: Haibo Chen <haibo.chen@xxxxxxx> > -- > 2.25.1
