Re: [PATCH v3 3/3] Input: Introduce goodix-i2c-hid as a subclass of i2c-hid

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Douglas,

I love your patch! Perhaps something to improve:

[auto build test WARNING on input/next]
[also build test WARNING on jikos-trivial/for-next linus/master v5.10-rc3 next-20201110]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Douglas-Anderson/dt-bindings-HID-i2c-hid-Introduce-bindings-for-the-Goodix-GT7375P/20201103-081548
base:   https://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git next
config: x86_64-randconfig-a016-20201110 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 4d81c8adb6ed9840257f6cb6b93f60856d422a15)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install x86_64 cross compiling tool for clang build
        # apt-get install binutils-x86-64-linux-gnu
        # https://github.com/0day-ci/linux/commit/528ad0eceb01a39e733c337c44500abd49b7bc2a
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Douglas-Anderson/dt-bindings-HID-i2c-hid-Introduce-bindings-for-the-Goodix-GT7375P/20201103-081548
        git checkout 528ad0eceb01a39e733c337c44500abd49b7bc2a
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All warnings (new ones prefixed by >>):

>> drivers/input/touchscreen/goodix-i2c-hid.c:90:34: warning: unused variable 'goodix_i2c_hid_of_match' [-Wunused-const-variable]
   static const struct of_device_id goodix_i2c_hid_of_match[] = {
                                    ^
   1 warning generated.

vim +/goodix_i2c_hid_of_match +90 drivers/input/touchscreen/goodix-i2c-hid.c

    89	
  > 90	static const struct of_device_id goodix_i2c_hid_of_match[] = {
    91		{ .compatible = "goodix,gt7375p", .data = &goodix_gt7375p_timing_data },
    92		{ }
    93	};
    94	MODULE_DEVICE_TABLE(of, goodix_i2c_hid_of_match);
    95	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux