Hi Lee,
On Wed, Nov 04, 2020 at 04:24:17PM +0000, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
>
> drivers/input/mouse/synaptics.c: In function ‘synaptics_process_packet’:
> drivers/input/mouse/synaptics.c:1110:6: warning: suggest braces around empty body in an ‘if’ statement [-Wempty-body]
>
> Cc: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>
> Cc: Henrik Rydberg <rydberg@xxxxxxxxxxx>
> Cc: Peter Osterlund <petero2@xxxxxxxxx>
> Cc: Stefan Gmeiner <riddlebox@xxxxxxxxxxx>
> Cc: "C. Scott Ananian" <cananian@xxxxxxxxxxxxxxxxxxx>
> Cc: Bruce Kalk <kall@xxxxxxxxxxx>
> Cc: this to <linux-input@xxxxxxxxxxxxxxx>
> Cc: linux-input@xxxxxxxxxxxxxxx
> Signed-off-by: Lee Jones <lee.jones@xxxxxxxxxx>
> ---
> drivers/input/mouse/synaptics.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c
> index 82577095e175e..07835939d83b9 100644
> --- a/drivers/input/mouse/synaptics.c
> +++ b/drivers/input/mouse/synaptics.c
> @@ -1106,8 +1106,9 @@ static void synaptics_process_packet(struct psmouse *psmouse)
> num_fingers = hw.w + 2;
> break;
> case 2:
> - if (SYN_MODEL_PEN(info->model_id))
> + if (SYN_MODEL_PEN(info->model_id)) {
> ; /* Nothing, treat a pen as a single finger */
> + }
This gives me:
WARNING: braces {} are not necessary for single statement blocks
from checkpatch.
Thanks.
--
Dmitry
