On Thu, Oct 29, 2020 at 02:57:15PM +0100, gregkh@xxxxxxxxxxxxxxxxxxx wrote: > On Thu, Oct 29, 2020 at 10:27:47PM +0900, HyungJae Im wrote: > > From: "hj2.im" <hj2.im@xxxxxxxxxxx> > > Date: Thu, 29 Oct 2020 22:11:24 +0900 > > Subject: [PATCH v2] input: add 2 kind of switch > > Why is this in the body of that patch? > > > > > We need support to various accessories on the device, > > some switch does not exist in switch list. > > So added switch for the following purpose. > > > > SW_COVER_ATTACHED is for the checking the cover > > attached or not on the device. SW_EXT_PEN_ATTACHED is for the > > checking the external pen attached or not on the device > > You didn't answer the previous question as to why the existing values do > not work for you instead of having to create new ones? > > > > > > Signed-off-by: Hyungjae Im <hj2.im@xxxxxxxxxxx> > > --- > > drivers/input/Kconfig | 20 ++ > > drivers/input/Makefile | 3 + > > drivers/input/cover_detect.c | 242 ++++++++++++++++++++++++ > > drivers/input/ext_pen_detect.c | 243 +++++++++++++++++++++++++ > > include/linux/mod_devicetable.h | 2 +- > > include/uapi/linux/input-event-codes.h | 4 +- > > 6 files changed, 512 insertions(+), 2 deletions(-) > > create mode 100644 drivers/input/cover_detect.c > > create mode 100644 drivers/input/ext_pen_detect.c > > If this is v2, what changed from v1? > > And this is 2 different drivers, it should be 2 different patches at the > least, right?> Actually the should simply use gpio-keys.c for this and dispense with the custom drivers. Thanks. -- Dmitry
