Re: [PATCH] HID: hid-input: occasionally report stylus battery even if not changed

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 27 Oct 2020, Dmitry Torokhov wrote:

> M
> On Wed, Oct 07, 2020 at 03:05:13PM -0700, Kenneth Albanowski wrote:
> > I've tested this locally backported to a 4.19 variant; it does work,
> > and provides the expected additional CHANGE events while safely
> > limiting the rate.
> > 
> > This seems like a reasonable minimum improvement, just ensuring
> > information already being pushed by HID reports can be utilized.
> > 
> > I'm unsure about mapping Digitizers.InRange to power_supply 'present',
> > in the abstract. It seems there could be a device where
> > Digitizers.BatteryStrength is sent, despite Digitizers.InRange=0, and
> > the HID Usage Tables don't quite seem to rule this out (depending on
> > how battery status collection interacts with 'the region where
> > digitizing is possible', section 16.3.1.).
> > 
> > As-is, this is useful and sufficient to get more timely reports up to userspace.
> 
> Jiri, if there are no better ideas, maybe this one can be applied?

Agreed (I certainly don't have better one :) ). Applied, thanks.

-- 
Jiri Kosina
SUSE Labs




[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux