On Tue, 27 Oct 2020, Hans de Goede wrote: > > The ASUS N-Key keyboard uses the productId of 0x1866 and is used in > > almost all modern ASUS gaming laptops with slight changes to the > > firmware. This patch enables: Fn+key hotkeys, keyboard backlight > > brightness control. > > > > Additionally this keyboard requires the LED interface to be > > initialized before such things as keyboard backlight control work. > > > > Signed-off-by: Luke D Jones <luke@xxxxxxxxxx> > > > > --- > > Changes v8-v10 > > - Remove asus_wmi_send_event and change Fn+F5 to emit > > KEY_PROG4. The ASUS G14-G15 laptops have a problem > > with freezes if the user spams this key to trigger > > asus_wmi_send_event(). It is better handled with a > > key-bind and daemon. > > - Change cases of dev_warn to hid_warn. > > - Remove out-of-scope changes which are better suited > > as separate patches. > > This version looks good to me, and it applies without problems > (no more removed spaces): > > Reviewed-by: Hans de Goede <hdegoede@xxxxxxxxxx> Applied, thanks Luke for putting this all together, and thanks Hans for such a detiled review. -- Jiri Kosina SUSE Labs
