21.10.2020 04:14, Wang, Jiada пишет: > Hello Dmitry and all > > Kind reminder on this patch-set Hello Jiada, Thinking a bit more about these patches, I'm coming back to the variant with the atmel,wakeup-method property. There are three possible wake-up variants for mXT1368: - NONE - GPIO - I2C-SCL and this series covers only the I2C-SCL. I was also skimming through datasheets of other maxtouch touchscreens and noticed that the retries aren't unique to mXT1368. For example mXT3432 controller also needs exactly the same retrying logic. Hence I think it should be better if we could generalize the wakeup-method in the device-tree. What do you think?