> -----Original Message-----
> From: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> Sent: Montag, 26. Oktober 2020 08:28
> To: Hennerich, Michael <Michael.Hennerich@xxxxxxxxxx>
> Cc: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>; linux-
> input@xxxxxxxxxxxxxxx; kernel-janitors@xxxxxxxxxxxxxxx
> Subject: [PATCH] Input: adxl34x - clean up a data type in adxl34x_probe()
>
> The "revid" is used to store negative error codes so it should be an int type.
>
> Fixes: e27c729219ad ("Input: add driver for ADXL345/346 Digital
> Accelerometers")
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Acked-by: Michael Hennerich <michael.hennerich@xxxxxxxxxx>
> ---
> drivers/input/misc/adxl34x.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/misc/adxl34x.c b/drivers/input/misc/adxl34x.c index
> 5fe92d4ba3f0..4cc4e8ff42b3 100644
> --- a/drivers/input/misc/adxl34x.c
> +++ b/drivers/input/misc/adxl34x.c
> @@ -696,7 +696,7 @@ struct adxl34x *adxl34x_probe(struct device *dev, int
> irq,
> struct input_dev *input_dev;
> const struct adxl34x_platform_data *pdata;
> int err, range, i;
> - unsigned char revid;
> + int revid;
>
> if (!irq) {
> dev_err(dev, "no IRQ?\n");
> --
> 2.28.0
