On Mon, Oct 19, 2020 at 12:54 PM Hans de Goede <hdegoede@xxxxxxxxxx> wrote:
> On 10/18/20 11:36 PM, Luke Jones wrote:
> >>> + if (report->id == FEATURE_KBD_LED_REPORT_ID1 ||
> >>> + report->id == FEATURE_KBD_LED_REPORT_ID2) {
> >>
> >>> + return -1;
> >>
> >> is -1 a good return code? (this Q for all cases)
> >>> + ret = asus_wmi_send_event(drvdata, 0xae);
> >>> + if (ret < 0) {
> >>> + hid_warn(hdev, "Asus failed to trigger fan control event");
> >>> + }
> >>
> >>> + return -1;
> >
> > In the case of this block I really don't have any idea how
> > to handle it. I want to stop these particular keycodes from
> > being evaluated elsewhere. Returning -1 seemed to be the only
> > way to do this, unless my understanding is very incorrect.
> >
> > Any help or guidance on how to handle this is definitely
> > appreciated.
>
> Sorry, I missed that Andy's comment on this where for the raw-event handler,
> in this case -1 has the special meaning of don't process this event further,
> rather then being an error code.
Good to know, thanks!
> So, since in this case -1 has a special meaning and it is NOT an error
> code, using -1 is fine. IOW you can keep this part as is.
I agree with Hans, you may ignore my question in those cases.
--
With Best Regards,
Andy Shevchenko
