On Wed, 7 Oct 2020 at 20:22, <kholk11@xxxxxxxxx> wrote: > > From: AngeloGioacchino Del Regno <kholk11@xxxxxxxxx> > > Add binding for the Novatek NT36xxx series touchscreen driver. > > Signed-off-by: AngeloGioacchino Del Regno <kholk11@xxxxxxxxx> > --- > .../input/touchscreen/novatek,nt36xxx.yaml | 56 +++++++++++++++++++ > 1 file changed, 56 insertions(+) > create mode 100644 Documentation/devicetree/bindings/input/touchscreen/novatek,nt36xxx.yaml > > diff --git a/Documentation/devicetree/bindings/input/touchscreen/novatek,nt36xxx.yaml b/Documentation/devicetree/bindings/input/touchscreen/novatek,nt36xxx.yaml > new file mode 100644 > index 000000000000..9f350f4e6d6a > --- /dev/null > +++ b/Documentation/devicetree/bindings/input/touchscreen/novatek,nt36xxx.yaml > @@ -0,0 +1,56 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/input/touchscreen/novatek,nt36xxx.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Novatek NT36xxx series touchscreen controller Bindings > + > +maintainers: > + - TBD Hi, It is surprising that this is your v3 and you put here TBD. In such case, add here subsystem maintainer: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx> > + > +allOf: > + - $ref: touchscreen.yaml# > + > +properties: > + compatible: > + enum: > + - novatek,nt36xxx This is not an enum, but one const. > + > + reg: > + enum: [ 0x62 ] Usually addresses are fixed in schema, because they could change (e.g. by some pin configuration). Just use maxItems: 1. > + > + interrupts: > + maxItems: 1 > + > + reset-gpio: > + maxItems: 1 > + > + vdd-supply: > + description: Power supply regulator for VDD pin > + > + vio-reg-name: > + description: Power supply regulator on VDD-IO pin What is this for? Is it a supply for the device or the device is a regulator provider? > + > +additionalProperties: false > + > +required: > + - compatible > + - reg > + - interrupts > + > +examples: > + - | > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + nt36xxx@62 { Incorrect node name - should be touchscreen. Best regards, Krzysztof
